vsk added a comment. In D84467#2448934 <https://reviews.llvm.org/D84467#2448934>, @alanphipps wrote:
> In D84467#2423636 <https://reviews.llvm.org/D84467#2423636>, @vsk wrote: > >> Thank you, lgtm! > > Thank you! I also would like to ask if you could commit it for me as I don't > have access for that. Note that a handful of tests have binary files which > were not uploaded with the diff. What do you advise I do to get those up > here so that I can commit it (unfortunately my system doesn't have arcanist > setup and that would take some time). Thanks again for all of your help! Unfortunately I don't think I'll be able to commit this on your behalf. Would you be open to obtaining commit access from Chris and landing this directly? I ask because, for a patch of this size, there's typically a fair amount of post-commit feedback (primarily in the form of bot failure notifications, but occasionally design feedback as well). It's common for tests to pass locally, but not on some specific CI node, and it can take quite a bit of time to resolve those issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84467/new/ https://reviews.llvm.org/D84467 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
