adamcz accepted this revision. adamcz added a comment. This revision is now accepted and ready to land.
Thanks, adding this test is a very good idea. ================ Comment at: clang/test/PCH/cxx17-deduction-guide-decl.cpp:16 + +// Class template argument deduction +template <typename T> ---------------- You can drop these 3 lines, they're not needed for the crash repro. Also, c-tor doesn't have to be explicit. Probably best to keep the code as short as possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92573/new/ https://reviews.llvm.org/D92573 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
