sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land.
Other than the nit, LGTM. ================ Comment at: clang/lib/Sema/SemaType.cpp:7789 + S.Diag(Attr.getLoc(), diag::err_attribute_unsupported) + << Attr << "'neon' or 'mve' feature flag"; Attr.setInvalid(); ---------------- nit: s/ feature flag// (otherwise, for this case it should be 'feature flags' and the case below would need 'the ' in front of it, to read nicely). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92487/new/ https://reviews.llvm.org/D92487 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits