sammccall added inline comments.
================ Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:89 + // Has cache been filled from disk? FIXME: this should be an expiry time. + bool CachePopulated = false; + // Whether a new CDB has been loaded but not broadcast yet. ---------------- All these members feel pretty messy, there's definitely some redundancy (e.g. `CachePopulated` is equivalent to `CDB || FinalizedNoCDB` at the moment). Basically this is an intermediate state: CachePopulated will become the validity time of the cached value (which *is* meaningful when CDB is set). I can try to polish this code in its own right, or optimize for a smooth transition to cache/expiry, but probably not both at once. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92381/new/ https://reviews.llvm.org/D92381 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
