tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
lgtm with a couple of minor nits noted below that you can fix before submitting
================
Comment at: clang/include/clang/Basic/CodeGenOptions.h:353
+ /// The threshold is an Optional value, which maps to one of the 3 states:
+ /// 1. 0 => threshold disabled. All emarks will be printed.
+ /// 2. positive int => manual threshold by user. Remarks with hotness exceed
----------------
nit: s/emarks/remarks/
================
Comment at: clang/include/clang/Basic/CodeGenOptions.h:358
+ /// available at command line, but will be synced with
+ /// hotness threhold from profile summary during
+ /// compilation.
----------------
nit: s/threhold/threshold/
================
Comment at: clang/test/Frontend/remarks-hotness.cpp:27
+// HOT_CALL: _Z7callee1v inlined into _Z7caller1v
+// HOT_CALL-NOT: _Z7callee2v not inlined into _Z7caller2v
+int caller1() {
----------------
nit: move this down by the corresponding REMARKS line below? (makes the
difference between the 2 cases clearer)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85808/new/
https://reviews.llvm.org/D85808
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
