hokein added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:203
};
+ struct D : B {
+ void [[f^oo]]() override {}
----------------
hmm, I'm not sure this is needed, I think it is identical with `C`.
================
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:618
+
+ // Templated method instantiation.
+ R"cpp(
----------------
nit: we have groups of templates on ~Line 215 already, I'd suggest to move
these template-related cases to there.
================
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:684
+
+ R"cpp(
+ template <typename T, int U>
----------------
nit: add a comment, this is variable template.
================
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:703
+ )cpp",
+ R"cpp(
+ template <typename T>
----------------
this test case is about function templates, move to Line 683.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91337/new/
https://reviews.llvm.org/D91337
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
