zinovy.nis marked an inline comment as done.
zinovy.nis added inline comments.
================
Comment at:
clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp:45
ifStmt(
hasCondition(ignoringParenImpCasts(anyOf(
declRefExpr(hasDeclaration(ImmutableVar)),
----------------
njames93 wrote:
> Just noticed, as this is ignoring Parenthesis and implicit nodes/casts, maybe
> we should also be ignoring those when getting the condition in the check
> `InnerIf->getCond()->IgnoreParenImpCasts()`
> I reckon if that change isnt made this could fail on
> ```lang=c++
> if (IsSet){
> if ((OtherCond && IsSet))
> ;
> }
> ```
You are right, thanks! I fixed it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91037/new/
https://reviews.llvm.org/D91037
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
