aaronpuchert added inline comments.
================
Comment at: clang/test/SemaCXX/implicitly-movable.cpp:14
+
+private:
+ A(const A &);
----------------
aaronpuchert wrote:
> Is this testing what we want it to test? The private functions are just not
> part of the overload set, right?
>
> I think you should make them public and `= delete` them.
Nevermind, private functions are part of the overload set, and compilation
fails on master, so this is fine.
================
Comment at: clang/test/SemaCXX/implicitly-movable.cpp:24-27
+A test_normal() {
+ A a_move;
+ return a_move;
+}
----------------
There is probably already a test for that, but I'll leave that to you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88295/new/
https://reviews.llvm.org/D88295
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
