pengfei added inline comments.
================
Comment at: clang/lib/Headers/amxintrin.h:69
+#undef __DEFAULT_FN_ATTRS
+
----------------
Better to use `__DEFAULT_FN_ATTRS_TILE`, `__DEFAULT_FN_ATTRS_INT8`, then you
don't need to undef it in the middle.
================
Comment at: clang/lib/Headers/amxintrin.h:230
+static __inline__ _tile_data __DEFAULT_FN_ATTRS
+_tile_loadd_internal(short m, short n, const void *base, int stride) {
+ return __builtin_ia32_tileloadd64_internal(m, n, base,
----------------
How about using the unsigned type?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87981/new/
https://reviews.llvm.org/D87981
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
