sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:42
+
+llvm::Optional<FoldingRange> toFoldingRange(LocInfo Begin, LocInfo End,
+                                            const SourceManager &SM) {
----------------
just use SourceLocations or SourceRange here? We have the SourceManager to 
decompose them anyway.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88553/new/

https://reviews.llvm.org/D88553

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to