Hiralo added a comment.

In D89936#2353048 <https://reviews.llvm.org/D89936#2353048>, @DmitryPolukhin 
wrote:

> ...I think this diff needs some improvements

Thanks @DmitryPolukhin for your valuable comments/feedback.
Please review updated patch.

> + test for new option.

I am planning to add following test-case...
<diff>
diff --git 
a/clang-tools-extra/test/clang-tidy/infrastructure/read_file_config.cpp 
b/clang-tools-extra/test/clang-tidy/infrastructure/read_file_config.cpp
.......
 // RUN: clang-tidy -checks="-*,clang-analyzer-*" %T/read-file-config/test.cpp 
| grep "warning: .*\[clang-analyzer-deadcode.DeadStores\]$"
+// RUN: clang-tidy -config-file=%T/read-file-config/.clang-tidy 
%T/read-file-config/test.cpp | grep "warning: 
.*\[clang-analyzer-deadcode.DeadStores\]$"
</diff>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89936/new/

https://reviews.llvm.org/D89936

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to