eduucaldas marked an inline comment as done. eduucaldas added a comment. In D90161#2353736 <https://reviews.llvm.org/D90161#2353736>, @gribozavr2 wrote:
> Could you add tests that verify the pairing of elements and delimiters? Those are surfaced through the previous tests, via `getElementsAsNodesAndDelimiters` ================ Comment at: clang/include/clang/Tooling/Syntax/Tree.h:442 + ElementAndDelimiterIterator<Node> + getElementsAsNodesAndDelimitersBeforeBegin(); + ElementAndDelimiterIterator<Node> getElementsAsNodesAndDelimitersBegin(); ---------------- What do you think? I didn't change it, because we had agreed on `ElementsAsNodesAndDelimiters`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90161/new/ https://reviews.llvm.org/D90161 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
