Author: Kirill Bobyrev Date: 2020-10-26T15:31:59+01:00 New Revision: 1704704e762f232e827849ee881ebe74b5db7ef1
URL: https://github.com/llvm/llvm-project/commit/1704704e762f232e827849ee881ebe74b5db7ef1 DIFF: https://github.com/llvm/llvm-project/commit/1704704e762f232e827849ee881ebe74b5db7ef1.diff LOG: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support Both `SymbolKind` and `indexSymbolKindToSymbolKind` support constructors and separate them into a different category from regular methods. Reviewed By: kadircet Differential Revision: https://reviews.llvm.org/D89935 Added: Modified: clang-tools-extra/clangd/FindSymbols.cpp clang-tools-extra/clangd/XRefs.cpp Removed: ################################################################################ diff --git a/clang-tools-extra/clangd/FindSymbols.cpp b/clang-tools-extra/clangd/FindSymbols.cpp index abd03ecb0464..d6908f7ab5fb 100644 --- a/clang-tools-extra/clangd/FindSymbols.cpp +++ b/clang-tools-extra/clangd/FindSymbols.cpp @@ -179,8 +179,8 @@ llvm::Optional<DocumentSymbol> declToSym(ASTContext &Ctx, const NamedDecl &ND) { return llvm::None; index::SymbolInfo SymInfo = index::getSymbolInfo(&ND); - // FIXME: this is not classifying constructors, destructors and operators - // correctly (they're all "methods"). + // FIXME: This is not classifying constructors, destructors and operators + // correctly. SymbolKind SK = indexSymbolKindToSymbolKind(SymInfo.Kind); DocumentSymbol SI; diff --git a/clang-tools-extra/clangd/XRefs.cpp b/clang-tools-extra/clangd/XRefs.cpp index 9469ab46c9fc..4c049803a5f9 100644 --- a/clang-tools-extra/clangd/XRefs.cpp +++ b/clang-tools-extra/clangd/XRefs.cpp @@ -1284,8 +1284,8 @@ declToTypeHierarchyItem(ASTContext &Ctx, const NamedDecl &ND) { SM, Lexer::getLocForEndOfToken(NameLoc, 0, SM, Ctx.getLangOpts())); index::SymbolInfo SymInfo = index::getSymbolInfo(&ND); - // FIXME: this is not classifying constructors, destructors and operators - // correctly (they're all "methods"). + // FIXME: This is not classifying constructors, destructors and operators + // correctly. SymbolKind SK = indexSymbolKindToSymbolKind(SymInfo.Kind); TypeHierarchyItem THI; _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
