dmikis added a comment. > If this usage leads to crashes, isn't the issue in DiagnosticsEngine itself?
I don't know design intent behind `DiagnosticsEngine`. As far as I can understand from source code it doesn't try to create any consumers by itself yet requires one to be provided (there're asserts that client is not `nullptr`). Reasonable thing to do may be to remove default for `client` parameter of `DiagnosticsEngine` constructor? I'm strugling to build whole LLVM under MSVC 19.27.29112 due to some weird problems with STL. I'll check later whether it's feasable to simply remove default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90121/new/ https://reviews.llvm.org/D90121 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
