MyDeveloperDay added a comment.

LGTM, only keep the tests if they remain passing, otherwise perhaps 
@JakeMerdichAMD  can add them back in.

Could you add a test for the thing that broke to keep us honest?

@JakeMerdichAMD when you get time, swing back round again with your fix because 
I think this was a good change (apart of the issues)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89464/new/

https://reviews.llvm.org/D89464

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to