aaron.ballman added a comment. A few minor nits remain.
Please run clang\docs\tools\dump_ast_matchers.py to regenerate the AST matcher documentation with your changes. ================ Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:5420 @@ -5409,1 +5419,3 @@ typedefDecl(hasName("typedefDeclTest")))); + EXPECT_FALSE(matches("using typedefDeclTest2 = int;", + typedefDecl(hasName("typedefDeclTest2")))); ---------------- Should be EXPECT_TRUE with notMatches(). ================ Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:5427 @@ +5426,3 @@ + typeAliasDecl(hasName("typeAliasTest2")))); + EXPECT_FALSE(matches("typedef int typeAliasTest;", + typeAliasDecl(hasName("typeAliasTest")))); ---------------- Should be EXPECT_TRUE with notMatches http://reviews.llvm.org/D19113 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits