zinovy.nis added a comment. In D89194#2323868 <https://reviews.llvm.org/D89194#2323868>, @JonasToth wrote:
> LGTM. > Short reminder to please use full context patches. Its not an issue right > now, but review sometimes just needs the context to understand the changes :) Sorry. Done. ================ Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4658 +/// functionDecl(isWeak()) +/// matches the weak declaration foo, but not bar. +AST_MATCHER(FunctionDecl, isWeak) { return Node.isWeak(); } ---------------- JonasToth wrote: > Short oversight. Please hightlight the code and matcher to make a > differentation in the docs. Sorry, I did not fully get what you mean as I just cloned isDefaulted section. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89194/new/ https://reviews.llvm.org/D89194 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits