sammccall accepted this revision.
sammccall added a comment.
Yeah, we can fairly easily make this tighter if it's noisy. My suspicion is
people will rather complain about ranking than these results being totally
irrelevant.
Nice that we now have workspace/symbols users that can send this feedback!
================
Comment at: clang-tools-extra/clangd/FindSymbols.cpp:47
+bool approximateScopeMatch(llvm::StringRef Scope, llvm::StringRef Query) {
+ // An empty query always matches the scope.
+ if (Query.empty())
----------------
there's no need for these to be special cases, the loop handles them correctly
It simplifies the asserts slightly, but seems like false economy
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88814/new/
https://reviews.llvm.org/D88814
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
