klimek added inline comments.
================
Comment at: clang/unittests/Format/FormatTest.cpp:8333
+TEST_F(FormatTest, UnderstandsUsesOfStarAndAmpInMacroDefinition) {
+ // This is a regression test for mis-parsing the & after decltype as a binary
----------------
arichardson wrote:
> arichardson wrote:
> > klimek wrote:
> > > I'd put this into a new test file that specifically tests annotations,
> > > perhaps AnnotationTest.cpp?
> > >
> > > Also, the test name seems misleading, as not all of these are macro
> > > definitions?
> > The regression is the second definition which is a macro definition, I
> > guess I could drop the first test.
> Moving it to a separate file probably makes sense, but then I'd have to drop
> the verifyFormat() calls.
If we start a new file, we can have 2 tests.
I'd leave the verifyFormat tests here, potentially putting them into already
existing test functions that test similar things.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88956/new/
https://reviews.llvm.org/D88956
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
