sepavloff added inline comments.
================ Comment at: clang/include/clang/Driver/Job.h:165 + const llvm::opt::ArgStringList &Arguments, ArrayRef<InputInfo> Inputs, + ArrayRef<InputInfo> Outputs); // FIXME: This really shouldn't be copyable, but is currently copied in some ---------------- yaxunl wrote: > Is this argument only used for reporting compile time and memory usage > statistics? > > Can it have a default empty argument? > > There are lots of out-of-tree code creating 'Command'. Requiring this > argument causes lots of hassles for them. Added default empty argument for `Output` in `Command`, `CC1Command` and `ForceSuccessCommand`. In `FallbackCommand` this parameter is not the last, it would require putting `None` manually. D78903 will be updated soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
