hokein added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1121
namespace ns { class [[Foo]] {}; }
- using ns::F^oo;
+ using ns::[[F^oo]];
)cpp",
----------------
sammccall wrote:
> I'd like to make a plan to solve this regression (we can do it here or in a
> followup patch, happy to hack on that).
>
> What do you think about the following heuristic:
> - if go-to-definition yields multiple results
> - and a particular result touches the cursor*
> - (optional) and that result is marked with Alias
> - then drop it from the set
> It means we still keep some special-case code, but it's not complex and
> fairly intuitive I think.
sounds good. I'd leave it as a follow-up. Added a FIXME.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88472/new/
https://reviews.llvm.org/D88472
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
