kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/FindSymbols.cpp:125 + Info.score = Score / Relevance.NameMatch; Top.push({Score, std::move(Info)}); ---------------- nit: maybe add a comment here too, explaining why we factor-out `NameMatch`. It wasn't obivous until i've read the comment below. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88844/new/ https://reviews.llvm.org/D88844 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits