MaskRay added inline comments.
================
Comment at: lld/Common/TargetOptionsCommandFlags.cpp:17
+llvm::TargetOptions
+lld::initTargetOptionsFromCodeGenFlags(const llvm::Triple &TheTriple) {
+ return llvm::codegen::InitTargetOptionsFromCodeGenFlags(TheTriple);
----------------
Currently lld does not need Triple. Consider not changing the signature of
`initTargetOptionsFromCodeGenFlags`.
================
Comment at: llvm/include/llvm/CodeGen/CommandFlags.h:142
+/// passed in.
+TargetOptions InitTargetOptionsFromCodeGenFlags(const llvm::Triple &TheTriple);
----------------
If you are going to change the signature, consider renaming it to
InitTargetOptionsFromCodeGenFlags to be consistent with the coding standard.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88737/new/
https://reviews.llvm.org/D88737
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
