adamcz accepted this revision. adamcz added a comment. This revision is now accepted and ready to land.
Still a couple of lint warnings, otherwise LGTM ================ Comment at: clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp:74 + for (auto _ : State) { + srand(0); + State.PauseTiming(); ---------------- Move this out of the loop. Right now we re-generate "random" dataset, but it's always the same dataset ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88590/new/ https://reviews.llvm.org/D88590 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits