BRevzin added inline comments.
================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h:167-171
-
-inline bool operator!=(const DWARFExpression::iterator &LHS,
- const DWARFExpression::iterator &RHS) {
- return !(LHS == RHS);
-}
----------------
lebedev.ri wrote:
> BRevzin wrote:
> > dblaikie wrote:
> > > Why are some being removed? That seems harder to justify. Even if they're
> > > not called, it may be more valuable to have the symmetry to reduce
> > > friction if/when they are needed. (iterators seem pretty common to
> > > compare for inequality - such as in a loop condition testing I != E)
> > They're not being removed. These functions still exist - it's just that now
> > they're being injected by the base class template with this exact signature
> > (rather than before where they were slightly different), so that now these
> > are redefinition issues.
> >
> > There's no loss of functionality here.
> Does LLVM still build fine in C++14/C++17 modes afterwards?
Yes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78938/new/
https://reviews.llvm.org/D78938
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
