zequanwu abandoned this revision. zequanwu added inline comments.
================ Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:353 + SkippedRanges.erase( + std::remove_if( + SkippedRanges.begin(), SkippedRanges.end(), ---------------- vsk wrote: > In the worst case, the work done in gatherSkippedRegions may still be n + > (n-1) + ... ~ O(n^2) (I'm subtracting 1 each time the skipped regions for a > function are erased). Yeah, just notice that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87648/new/ https://reviews.llvm.org/D87648 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
