yaxunl marked an inline comment as done. yaxunl added inline comments.
================ Comment at: clang/lib/Basic/Targets/AMDGPU.h:419 + + if (llvm::find(Features, "+wavefrontsize64") != Features.end()) + WavefrontSize = 64; ---------------- arsenm wrote: > Why is this not redundant with the features check? You mean the above check for target ID features? It only checks features in target ID, i.e. xnack and sramecc. ================ Comment at: clang/test/Driver/amdgpu-macros.cl:351 + +// GFX600-DAG: #define __amdgcn_wavefront_size 64 +// GFX601-DAG: #define __amdgcn_wavefront_size 64 ---------------- arsenm wrote: > Macros should be all caps will change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88370/new/ https://reviews.llvm.org/D88370 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
