aaron.ballman added a comment. Thank you for the changes, but do you know of any tests that are impacted by this? I'm not opposed to the proposed changes, but I am wondering -- the current behavior is that an empty output file (which can happen with especially egregious bugs) is always an error but if I understand the proposed patch, that may now be silently accepted as a passing test? So I'm wondering if we want to require something like `// expected-no-diagnostics` from the `-verify` command in Clang so that users have to explicitly opt a test into the behavior? Or should this not be an issue in general because `// CHECK` lines should still be present in the test and those will fail when compared against an empty file?
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87830/new/ https://reviews.llvm.org/D87830 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits