tra marked an inline comment as done.
tra added a comment.

In D88250#2293270 <https://reviews.llvm.org/D88250#2293270>, @jlebar wrote:

> I know it comes in a separate change, but can we add a check to the 
> test-suite?

Will do.



================
Comment at: clang/lib/Headers/__clang_cuda_runtime_wrapper.h:381
+__device__ inline __cuda_builtin_threadIdx_t::operator dim3() const {
+  return {x, y, z};
+}
----------------
jlebar wrote:
> This is a C++11-ism (right?).  Do we support compiling without C++11?
Fixed. 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88250/new/

https://reviews.llvm.org/D88250

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to