dberris added inline comments.

================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:817
+                                        CurFn->getName().bytes_end());
+      auto Group = crc32(FuncName) % FuncGroups;
+      if (Group != CGM.getCodeGenOpts().XRaySelectedFunctionGroup &&
----------------
I'm a little concerned that this is randomly determined. Could we think about 
using a function attribute instead that opts functions into groups by name? Or 
is the intent to have "sampling" in the coverage information instead of full 
coverage?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87953/new/

https://reviews.llvm.org/D87953

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to