ro added a subscriber: vitalybuka.
ro added a comment.
In D87615#2273427 <https://reviews.llvm.org/D87615#2273427>, @ro wrote:
>
> Tested on `amd64-pc-solaris2.11`. However, compared to the `-mstackrealign`
> version
> there's one regression that I still need to investigate:
>
> UBSan-Standalone-i386 :: TestCases/TypeCheck/vptr.cpp
This turns out to be just a whitespace difference: before the stack alignment
patch I'd get for the `mS` subtest:
Test case: mS
/vol/llvm/src/llvm-project/dist/compiler-rt/test/ubsan/TestCases/TypeCheck/vptr.cpp:169:15:
runtime error: member access within address 0xfeffdcf0 which does not point to
an object of type 'T'
0xfeffdcf0: note: object is of type 'S'
76 62 92 92 ec 1b 06 08 00 00 00 00 44 de ff fe 30 dd ff fe 00 00 00 00
00 00 00 00 00 00 00 00
^~~~~~~~~~~
vptr for 'S'
After the patch I see instead:
Test case: mS
/vol/llvm/src/llvm-project/dist/compiler-rt/test/ubsan/TestCases/TypeCheck/vptr.cpp:169:15:
runtime error: member access within address 0xfeffdd34 which does not point to
an object of type 'T'
0xfeffdd34: note: object is of type 'S'
76 62 92 92 ec 1b 06 08 00 00 00 00 78 dd ff fe 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00
^~~~~~~~~~~
vptr for 'S'
i.e. one additional blank at the beginning of the line and a different
grouping. I have no idea about the significance of those: @vitalybuka?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87615/new/
https://reviews.llvm.org/D87615
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
