yaxunl added inline comments.
================
Comment at: clang/test/Driver/gz.c:1
+// RUN: %clang -### -target x86_64-unknown-linux-gnu -g -gz=none %s 2>&1 | \
+// RUN: FileCheck -check-prefix=NONE %s
----------------
MaskRay wrote:
> This can be merged into `compress.c`
> You may delete some `-c` from compress.c to exercise the linker stage.
done
================
Comment at: clang/test/Driver/hip-gz-options.hip:1
+// REQUIRES: clang-driver
+// REQUIRES: x86-registered-target
----------------
MaskRay wrote:
> REQUIRES values can be comma separated
merged
================
Comment at: clang/test/Driver/hip-gz-options.hip:5
+
+// RUN: %clang -### --offload-arch=gfx906 %s -nogpulib -nogpuinc \
+// RUN: -ggdb -gz=zlib 2>&1 | FileCheck %s
----------------
MaskRay wrote:
> Is `-target` (or `--target=`) needed?
yes. added
================
Comment at: clang/test/Driver/hip-gz-options.hip:15
+// CHECK: {{".*ld.*" .* "--compress-debug-sections=zlib"}}
+
----------------
MaskRay wrote:
> Delete trailing empty lines
done
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87321/new/
https://reviews.llvm.org/D87321
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
