nhaehnle added a comment. >> ReplaceNodeResults expects the result type to be changed in semi-magical >> ways during vector type legalization, which is non-obvious since the method >> can be called from different places. I think it *could* be made to work with >> a lot of patience, but it's really a bad interface -- and besides, by doing >> it in IR we reduce code duplication between SelectionDAG and GlobalISel, >> which is an added benefit IMO. > > Well the globalisel handling should be much simpler. We have a lot of stuff > that's randomly handled in the IR to work around the DAG which long term > should be moved where it belongs in codegen
Is the GlobalISel handling simpler than the handling in IR? What would happen if we wanted to extend the handling to struct types? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86154/new/ https://reviews.llvm.org/D86154 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
