gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land.
> Perhaps we should inline getQualifiedNameStart and getInitializerRange and > make getDeclaratorRange a member function taking a Decl. What do you think? These helpers seem to have well-defined semantics, so I'd rather keep them separate. If anything, I'd make helpers into free functions to emphasize that they don't use the class member variables and are standalone functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86719/new/ https://reviews.llvm.org/D86719 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
