jhenderson added a comment. This looks reasonable to me, but I don't know the surrounding code well enough to be comfortable LGTM-ing it. Sorry!
================ Comment at: llvm/include/llvm/MC/MCAsmInfo.h:387 + // Generated object files can only use features support by GNU ld of this + // binutils version. ---------------- This sentence implies this specific version, but I think it's meant to be a minimum. If so, I'd add "or later" to the end of the sentence. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://reviews.llvm.org/D85474 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits