aganea added inline comments.

================
Comment at: clang/test/Driver/cl-options.c:685
 
+// vctoolsdir is handled by the driver; just check that we don't error. Pass 
-c because fakedir isn't a real toolchain path
+// RUN: %clang_cl -c -vctoolsdir fakedir -- %s 2>&1
----------------
One more thing: I would avoid long lines, and try to stay as much as possible 
within the 80 char per line limit. There's no hard rule for the tests as you 
can see in the file above, but it's a nice to have.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85998/new/

https://reviews.llvm.org/D85998

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to