bruno added a comment.
Hi Wei, this looks handy! Minor stylish comments below.
================
Comment at: clang/include/clang/Driver/Driver.h:638
+/// This checks for clang specific R-value ('-Rpass-*') group.
+bool hasRpassOptions(const llvm::opt::ArgList &Args);
+
----------------
Nitpicking here, how about `usesRpassOptions`?
================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:67
+ A->getValue()));
+ }
+
----------------
You can also remove curly braces from here.
================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:72
+ Twine("--plugin-opt=-pass-remarks-missed=") + A->getValue()));
+ }
+
----------------
and here.
================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:77
+ Twine("--plugin-opt=-pass-remarks-analysis=") + A->getValue()));
+ }
+}
----------------
and here.
================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:99
+ F = llvm::sys::path::stem(Input.getBaseInput());
+ }
+ }
----------------
and here, hoist the comment above the `if`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85810/new/
https://reviews.llvm.org/D85810
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
