gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:2151
+
+TEST_P(SyntaxTreeTest, Namepace_UsingDirective) {
+ if (!GetParam().isCXX()) {
----------------
I think grouping this test under Namespace_ is not the best choice, because
what's being tested here is the `using`, not the `namespace`.
================
Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:2171
+
+TEST_P(SyntaxTreeTest, Namespace_UsingDeclaration) {
+ if (!GetParam().isCXX()) {
----------------
Ditto.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86139/new/
https://reviews.llvm.org/D86139
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
