sammccall added inline comments.
================ Comment at: clang/test/PCH/preamble-modules.cpp:8 + +#ifndef MAIN_FILE +#define MAIN_FILE ---------------- what are these ifdefs about? you never seem to define this symbol (Possible you're copying from a test that is doing something tricky like being run in two modes or including itself? Or did you mean to give different flags for the include vs emit pch?) ================ Comment at: clang/test/PCH/preamble-modules.cpp:14 +// Main section. +MyType foo; +#endif ---------------- This seems like currently it's never getting parsed as MAIN_FILE is never defined. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86069/new/ https://reviews.llvm.org/D86069 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
