gribozavr2 accepted this revision.
gribozavr2 added a comment.
This revision is now accepted and ready to land.
Very nice improvement to tests!
================
Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:784
+
+TEST_P(SyntaxTreeTest, QualifiedId_ComplexDeclaration) {
+ if (!GetParam().isCXX()) {
----------------
The name of this test should be about declarations, and this test should be in
the section of this file that has to do with declarations.
================
Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:1010
+
+TEST_P(SyntaxTreeTest, UserDefinedLiteral_Typedef) {
+ if (!GetParam().isCXX11OrLater()) {
----------------
The name of this test should be only about typedefs, and not about user-defined
literals. The test should be also in the section of this file that is about
declarations (down below).
================
Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:2545
+ R"cpp(
+template <class T> int var = 10;
+)cpp",
----------------
I think it should be `T var`, otherwise `T` is not used (not using `T` is
valid, but rather unusual).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85962/new/
https://reviews.llvm.org/D85962
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
