JonChesterfield added inline comments.

================
Comment at: clang/test/Sema/attr-loader-uninitialized.cpp:14
+extern S incomplete_external_rejected __attribute__((loader_uninitialized));
+// expected-error@-1 {{variable has incomplete type 'S'}}
+// expected-note@-3 {{forward declaration of 'S'}}
----------------
erichkeane wrote:
> Should this give the 'cannot be declared 'extern' and with the 
> 'loader_uninitialized' attribute?' error instead?  it seems to make more 
> sense there, and is more specific.
It probably should, yes. I'll see whether I can hit that diagnostic instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85990/new/

https://reviews.llvm.org/D85990

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to