Okey dokey - I know one of the things we did (& I don't know when it happened compared to this change) is emit a hard list of variables onto any subprogram for an optimized (non -O0) function. So we never lose variables due to optimizations, or at least that's the intent.
As for D18477, I'm not sure why collectDeadVariables became dead with your change - I imagine we still want to stuff dead variables into the subprograms we did create (the ones that weren't /entirely/ optimized away (ones with remaining inlined instances, etc)) - but maybe we do that elsewhere? On Tue, Apr 5, 2016 at 3:14 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > aprantl abandoned this revision. > aprantl added a comment. > > Meanwhile I made an experiment and compiled XNU with > http://reviews.llvm.org/D18477 and compared the debug info from before > and after and found no missing types at all. It is plausible that r107027 > was added to work around the fact that six years ago LLVM was a lot worse > at preserving debug info for local variables. It is also possible that the > call graph of the kernel changed in the mean time or a combination of both. > > > Repository: > rL LLVM > > http://reviews.llvm.org/D18565 > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
