aaron.ballman added a comment. I have a suggestion for the added comment, but I also forgot to ask, do you need someone to commit on your behalf?
================ Comment at: clang/lib/Sema/SemaInit.cpp:3094 + // This initializer overwrites a previous initializer. + // Emit warning if `expr` is valid. + if (expr) ---------------- I was hoping for something that describes the "why" more than the "what". How about: `No need to diagnose when expr is null because a more relevant diagnostic has already been issued and this diagnostic is potentially noise.` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85193/new/ https://reviews.llvm.org/D85193 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
