alexfh accepted this revision.
alexfh added a comment.
LG with a couple of comments. Do you need someone to land the patch for you?
================
Comment at: clang-tools-extra/clang-tidy/add_new_check.py:139
const auto *MatchedDecl = Result.Nodes.getNodeAs<FunctionDecl>("x");
- if (MatchedDecl->getName().startswith("awesome_"))
+ if ((!MatchedDecl->getIdentifier()) ||
MatchedDecl->getName().startswith("awesome_"))
return;
----------------
No need for parentheses around this.
================
Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:205
+ const auto *MatchedDecl = Result.Nodes.getNodeAs<FunctionDecl>("x");
+ if ((!MatchedDecl->getIdentifier()) ||
MatchedDecl->getName().startswith("awesome_"))
return;
----------------
ditto.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85218/new/
https://reviews.llvm.org/D85218
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
