I'm not sure I understand what this test has to do with VS2013. Clang-tidy should be able to parse this code, and if it doesn't (e.g. due to -fms-compatibility being turned on by default on windows), we should put unsupported constructs under an appropriate #ifdef, not comment them out completely.
On Mon, Mar 28, 2016 at 6:15 AM, Richard Thomson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: legalize > Date: Sun Mar 27 23:15:41 2016 > New Revision: 264563 > > URL: http://llvm.org/viewvc/llvm-project?rev=264563&view=rev > Log: > clang-tidy: Fix broken buildbot > > VS 2013 does not support char16_t or char32_t > > Modified: > > clang-tools-extra/trunk/test/clang-tidy/modernize-raw-string-literal.cpp > > Modified: > clang-tools-extra/trunk/test/clang-tidy/modernize-raw-string-literal.cpp > URL: > http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/modernize-raw-string-literal.cpp?rev=264563&r1=264562&r2=264563&view=diff > > ============================================================================== > --- > clang-tools-extra/trunk/test/clang-tidy/modernize-raw-string-literal.cpp > (original) > +++ > clang-tools-extra/trunk/test/clang-tidy/modernize-raw-string-literal.cpp > Sun Mar 27 23:15:41 2016 > @@ -46,10 +46,12 @@ char const *const TrailingNewLine("A sin > char const *const AlreadyRaw(R"(foobie\\bletch)"); > char const *const UTF8Literal(u8"foobie\\bletch"); > char const *const UTF8RawLiteral(u8R"(foobie\\bletch)"); > -char16_t const *const UTF16Literal(u"foobie\\bletch"); > -char16_t const *const UTF16RawLiteral(uR"(foobie\\bletch)"); > -char32_t const *const UTF32Literal(U"foobie\\bletch"); > -char32_t const *const UTF32RawLiteral(UR"(foobie\\bletch)"); > +// TODO: enable these tests once all supported compilers > +// support char16_t and char32_t (VS2013 does not) > +// char16_t const *const UTF16Literal(u"foobie\\bletch"); > +// char16_t const *const UTF16RawLiteral(uR"(foobie\\bletch)"); > +// char32_t const *const UTF32Literal(U"foobie\\bletch"); > +// char32_t const *const UTF32RawLiteral(UR"(foobie\\bletch)"); > wchar_t const *const WideLiteral(L"foobie\\bletch"); > wchar_t const *const WideRawLiteral(LR"(foobie\\bletch)"); > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
