ArcsinX added inline comments.
================ Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-not-null-terminated-result-stdc-want-lib-ext1-not-a-literal.c:3 +// RUN: -- -std=c11 -I %S/Inputs/bugprone-not-null-terminated-result + +#include "not-null-terminated-result-c.h" ---------------- hokein wrote: > I think you probably need a `// UNSUPPORTED: system-windows`, as the > `bugprone-not-null-terminated-result-strlen.c` does. Seems we don't need this. Problem with `bugprone-not-null-terminated-result-strlen.c` test on Windows related with `strncmp`, according with comment. ``` // FIXME: Something wrong with the APInt un/signed conversion on Windows: // in 'strncmp(str6, "string", 7);' it tries to inject '4294967302' as length. // UNSUPPORTED: system-windows ``` E.g. `bugprone-not-null-terminated-result-memcpy-safe` also uses `strlen` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85525/new/ https://reviews.llvm.org/D85525 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
