tatyana-krasnukha added a comment.
I'm not familiar with the z/OS target, so I cannot check the correctness of the
target-specific changes. The overall patch looks good.
================
Comment at: clang/lib/Basic/Targets/OSTargets.h:780
+public:
+ ZOSTargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
+ : OSTargetInfo<Target>(Triple, Opts) {}
----------------
It is possible to use inheriting constructor here instead (i.e. `using
OSTargetInfo<Target>::OSTargetInfo;`).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85324/new/
https://reviews.llvm.org/D85324
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
