tra added a comment.

LGTM for CUDA.



================
Comment at: clang/lib/CodeGen/CodeGenPGO.cpp:839-840
 
+  // Skip host-only functions in the CUDA device compilation and device-only
+  // functions in the host compilation.
+  if (CGM.getLangOpts().CUDA &&
----------------
We will still have around some functions that may never be used on the host 
side (HD functions referenced from device code only).  I'm not sure if that's a 
problem for profiling, though. I wonder if we can somehow tie 
`skipRegionMappingForDecl` to whether we've actually codegen'ed the function. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85276/new/

https://reviews.llvm.org/D85276

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to