ebevhan added a comment.

In D83325#2170813 <https://reviews.llvm.org/D83325#2170813>, @rjmccall wrote:

> `removeAddrSpaceQualType` should guarantee that it removes the address space 
> qualifier; you shouldn't need to do something special here.  That means it 
> needs to iteratively desugar and collect qualifiers as long as the type is 
> still address-space-qualified.

Well, from what I observed, it is not doing that, so perhaps that's what needs 
to be addressed. That's a bit more involved, though.

We will still end up stripping all sugar up until we hit the AS-qualification, 
though. Unless we are supposed to reconstitute the sugared type with the AS 
altered somehow?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83325/new/

https://reviews.llvm.org/D83325

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D83325: [Sema] Be mo... Bevin Hansson via Phabricator via cfe-commits

Reply via email to