arames marked 2 inline comments as done. arames added inline comments.
================ Comment at: clang/docs/Modules.rst:295 + +A trick to prebuilt required modules in one command is to generate implicit modules using the ``-fdisable-module-hash`` option. + ---------------- Bigcheese wrote: > I also think it's important to point out here that disabling the module hash > means you are responsible for making sure the modules are compatible. How to > do this is mentioned below, but it's never stated why you would want to do > this. Fixed the typo. Good point. I am refactoring the examples to make everything clearer. ================ Comment at: clang/docs/Modules.rst:303 + # prebuilt/A.pcm prebuilt/B.pcm + clang -cc1 -x c use.c -fmodules -fprebuilt-module-path=prebuilt -o /use.o + ---------------- Fixed a few other typos in the examples as well. ================ Comment at: clang/test/Modules/prebuilt-implicit-modules.m:9 +// RUN: %clang_cc1 -x objective-c %s -I%S/Inputs/prebuilt-implicit-module -fmodules -fmodule-map-file=%S/Inputs/prebuilt-implicit-module/module.modulemap -fprebuilt-implicit-modules -fprebuilt-module-path=%t -fmodules-cache-path=%t1 +// RUN: find %t1 -name "module_a*.pcm" | not grep module_e +// ---------------- Bigcheese wrote: > Is this actually supposed to be `module_e`? I would expect this to be > verifying that it didn't add `module_a` to `%t1`. That was a typo. Fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
